Skip to content

Update run.sh to use arm-none-eabi-size #7125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2024
Merged

Update run.sh to use arm-none-eabi-size #7125

merged 1 commit into from
Nov 29, 2024

Conversation

@AIWintermuteAI
Copy link
Contributor

@AIWintermuteAI AIWintermuteAI commented Nov 28, 2024

Summary

As discussed in #7104, it's preferred to use arm-none-eabi-size to determine the binary size, as built-in size will not be able to correctly read ARM binary on all platforms.

Fixes #7104.

Test plan

Ran run.sh on Mac M1.

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 28, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7125

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit ed51e90 with merge base e83ab0e (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 28, 2024

Hi @AIWintermuteAI!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 28, 2024
@zingo zingo added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Nov 28, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 28, 2024

Please seek CI approval before scheduling CIFlow labels

zingo
zingo approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@zingo zingo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. And welcome as a contributor to the project .

@freddan80 freddan80 merged commit 3475707 into pytorch:main Nov 29, 2024
39 of 44 checks passed
@AIWintermuteAI AIWintermuteAI deleted the patch-1 branch December 4, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zingo zingo zingo approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

arm_executor_runner is not an object file

4 participants

@AIWintermuteAI @facebook-github-bot @zingo @freddan80